Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA-226 Updates UI to use the new Ethyca brand colors #5668

Merged
merged 58 commits into from
Jan 17, 2025

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jan 14, 2025

Description Of Changes

Update Chakra theme and components to use new Ethyca brand colors and standardize the looks of some components like Badges.

Code Changes

  • Update Chakra theme primary, secondary, complementary palettes
  • Added new colors to Chakra theme
  • Standardized the look of badges
  • Updated admin homepage to use Cards

Steps to Confirm

Admin-UI

  1. Browse around admin-ui pages
  2. Check no purple or deep blue colors are present, they should be replaced with minos black
  3. Check that the Fides logo is updated to it's uppercase version
  4. Check that the homepage doesn't show an image, the links should now be gray cards with a left border of different colors

Privacy Center

  1. Open privacy center homepage
  2. Check icons are now Minos black instead of purple
  3. Go to manage consent
  4. Check the toggles are Minos black instead of purple

Fides-JS

  1. Make sure you have a valid US Experience to test the fides-js modal:
  2. Run the fides-js build, go to clients/fides-js and run npm run build
  3. Go to http://localhost:3001/fides-js-demo.html?geolocation=us-ca&fides_locale=us
  4. Click on Manage preferences
  5. Check that the the modal now displays the button and the toggles in Minos black color instead of purple

Screenshots

Admin-UI
Screen Shot 2025-01-14 at 12 04 12

Privacy Center
Screen Shot 2025-01-14 at 12 05 17
Screen Shot 2025-01-14 at 12 44 00

Fides JS Banner, Modal, TCF
Screen Shot 2025-01-14 at 12 19 01
Screen Shot 2025-01-14 at 12 23 57
Screen Shot 2025-01-14 at 12 24 02
Screen Shot 2025-01-14 at 12 25 08

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 5:34pm

Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Can't wait for this to get merged in :)

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (6459162) to head (88ed0c9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5668      +/-   ##
==========================================
+ Coverage   84.94%   87.14%   +2.20%     
==========================================
  Files         388      388              
  Lines       24033    24033              
  Branches     2594     2594              
==========================================
+ Hits        20414    20943     +529     
+ Misses       3055     2529     -526     
+ Partials      564      561       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucanovera lucanovera merged commit fdd8b4b into main Jan 17, 2025
43 checks passed
@lucanovera lucanovera deleted the LA-226-finish-chakra-color-theme-update branch January 17, 2025 18:06
Copy link

cypress bot commented Jan 17, 2025

fides    Run #11834

Run Properties:  status check passed Passed #11834  •  git commit fdd8b4bcba: LA-226 Updates UI to use the new Ethyca brand colors (#5668)
Project fides
Branch Review main
Run status status check passed Passed #11834
Run duration 00m 40s
Commit git commit fdd8b4bcba: LA-226 Updates UI to use the new Ethyca brand colors (#5668)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants